Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fractal registry contract from base contracts #1652

Merged
merged 3 commits into from
May 7, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented May 6, 2024

Please review and merge #1651 first.

@adamgall adamgall self-assigned this May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit 02ed6ce
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/663a6b6866b96b0008a25952
😎 Deploy Preview https://deploy-preview-1652.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall force-pushed the network-config-exports-address-types branch from 7082c40 to 84cb2d1 Compare May 6, 2024 03:35
@adamgall adamgall force-pushed the remove-fractalRegistryContract-from-BaseContracts branch from 4622e6d to 59c4ecc Compare May 6, 2024 03:35
@adamgall adamgall force-pushed the network-config-exports-address-types branch from 84cb2d1 to 230c68b Compare May 6, 2024 19:07
@adamgall adamgall force-pushed the remove-fractalRegistryContract-from-BaseContracts branch from 59c4ecc to e5ce3aa Compare May 6, 2024 19:09
@adamgall adamgall force-pushed the network-config-exports-address-types branch from 230c68b to 55a87fe Compare May 6, 2024 19:23
@adamgall adamgall force-pushed the remove-fractalRegistryContract-from-BaseContracts branch 2 times, most recently from 62fc822 to fb71f34 Compare May 6, 2024 19:28
@adamgall adamgall force-pushed the network-config-exports-address-types branch from 55a87fe to 19825b7 Compare May 6, 2024 19:28
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamgall
Copy link
Member Author

adamgall commented May 7, 2024

@Da-Colon j/w did you mean to leave your review as a comment? or an approval

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opps approved

@adamgall adamgall force-pushed the network-config-exports-address-types branch from 19825b7 to 725f375 Compare May 7, 2024 17:55
@adamgall adamgall force-pushed the remove-fractalRegistryContract-from-BaseContracts branch from fb71f34 to 02ed6ce Compare May 7, 2024 17:56
Base automatically changed from network-config-exports-address-types to develop May 7, 2024 23:18
@adamgall adamgall marked this pull request as ready for review May 7, 2024 23:18
@adamgall adamgall merged commit 3434909 into develop May 7, 2024
7 checks passed
@adamgall adamgall deleted the remove-fractalRegistryContract-from-BaseContracts branch May 7, 2024 23:18
adamgall added a commit that referenced this pull request May 8, 2024
…t-from-BaseContracts

Remove fractal registry contract from base contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants